Repository navigation
FIX / Make glpi_plugin_jamf_devices.jamf_items_id unsigned - #45
Merged
Merged
Conversation
jdurand-teclib
approved these changes
Oct 14, 2026
Rom1-B
self-requested a review
October 19, 2026 11:52
Rom1-B
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
php bin/console migration:unsigned_keyson an instance with the Jamf plugin fails with "Migration of column "glpi_plugin_jamf_devices.jamf_items_id" cannot be done as its default value is negative." The column was created by the 2.1.0 migration as a signedint(11)with a default value of -1, inherited from the old "no Jamf ID" placeholder, so the core command refuses to convert it, and it would also refuse to convert it if any row still held -1.A new 3.2.4 migration step sets any negative
jamf_items_idvalues to 0 and then converts the column to the standard unsigned foreign key type with a default value of 0. A unit test rebuilds the legacy column definition with a -1 row and checks that the migration leaves the column unsigned and that the row is updated.